Adds support for fractional units to next_/last_ week/day/hour/minute… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Months and years are stupid. |
|
Thanks for the pull request. Adding some tests would help, make sure you verify that whole numbers continue to work and update the documentation accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/second.
Re: issue #75, this appears to be related to dateutil/dateutil#40 + https://github.com/myusuf3/delorean/blob/master/delorean/dates.py#L295. It looks like some sort of official relativedelta float-support for fractional years/months might be coming in the 2.5.0 release of dateutils. In the meantime, floats do work with relativedelta for weeks down to microseconds.
This patch adds support for those. If you think this is a worthwhile idea, I'm happy to write some tests for it.