Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AI Transform Node): UX improvements #11280

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

feat(AI Transform Node): UX improvements #11280

wants to merge 33 commits into from
+208 −71

Conversation

michael-radency
Copy link
Contributor

Summary

  • If the Code is empty or if I edited the prompt and I click on “Test step”, generate the code first
  • If you edit the prompt and forget to click ‘generate code’ before running the node, show a warning
  • “Transformation Code” -> “Generated JavaScript”
  • “Reset value” -> “Clear contents”
  • tooltip for the code param -> hint at the bottom of the code box instead

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1864/improve-ux-in-ai-transform-node

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Oct 16, 2024
@michael-radency
generate code on test button click if missed
d98a4fc
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
f3f8df9 
…improve-ux-in-ai-transform-node
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
483352f 
…improve-ux-in-ai-transform-node
@michael-radency
improvements
7f0efc1
@michael-radency
test update
8aef298
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
78fa618 
…improve-ux-in-ai-transform-node
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
ac0407a 
…improve-ux-in-ai-transform-node
@michael-radency
review update
2f571e2
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
3b0bbb5 
…improve-ux-in-ai-transform-node
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
a2c5cab 
…improve-ux-in-ai-transform-node
@michael-radency
counter/warning backdrop
5450c7a
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
d820454 
…improve-ux-in-ai-transform-node
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1864-…
ef616ba 
…improve-ux-in-ai-transform-node
@michael-radency
test fix
80fee44
ShireenMissi
ShireenMissi reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Manually all words as expected 🎉
left some minor spelling comments
also a test is failing

packages/editor-ui/src/components/ButtonParameter/utils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/NodeExecuteButton.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-radency @ShireenMissi