Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add optional chaining to nodeExecutionRunData in node execution status (no-changelog) #11370

Merged

Conversation

alexgrozav
Copy link
Contributor

Summary

Fixes recurring sentry issue.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-263/typeerror-nodeexecutionrundatafilter[0]-is-undefined

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Oct 23, 2024
@alexgrozav alexgrozav force-pushed the cat-263-typeerror-nodeexecutionrundatafilter0-is-undefined branch from 69148d6 to e0bc5e4 Compare October 23, 2024 12:32
@alexgrozav alexgrozav changed the title fix(editor): Add optional chaining to nodeExecutionRunData in node execution status fix(editor): Add optional chaining to nodeExecutionRunData in node execution status (no-changelog) Oct 23, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 23, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 29, 2024

n8n    Run #7652

Run Properties:  status check passed Passed #7652  •  git commit 1f2742d2c4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-263-typeerror-nodeexecutionrundatafilter0-is-undefined
Run status status check passed Passed #7652
Run duration 58m 56s
Commit git commit 1f2742d2c4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 1, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 602355a into master Nov 1, 2024
33 checks passed
@alexgrozav alexgrozav deleted the cat-263-typeerror-nodeexecutionrundatafilter0-is-undefined branch November 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants