-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views #11445
Merged
cstuncsik
merged 6 commits into
master
from
pay-2168-auto-focus-email-field-on-sign-in-page
Nov 1, 2024
Merged
fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views #11445
cstuncsik
merged 6 commits into
master
from
pay-2168-auto-focus-email-field-on-sign-in-page
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, can we also add focusInitially
on
firstName
field inSignupView
, andemail
field inForgotMyPasswordView
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 29, 2024
cstuncsik
changed the title
fix(editor): Auto focus email field on sign-in view
fix(editor): Auto focus first fields on SignIn, SignUp and ForgotMyPassword views
Oct 29, 2024
netroy
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏽
n8n Run #7644
Run Properties:
|
Project |
n8n
|
Branch Review |
pay-2168-auto-focus-email-field-on-sign-in-page
|
Run status |
Passed #7644
|
Run duration | 04m 24s |
Commit |
dc14556e4e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
|
Committer | Csaba Tuncsik |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
460
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve UX for SignIn, SignUp, and ForgotMyPassword by focusing on the first input
Related Linear tickets, Github issues, and Community forum posts
PAY-2168
Review / Merge checklist