Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix rendering of AI logs #11450

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

This PR updates how we handle and display AI execution logs in the OutputPanel to align with the recent supply node refactoring (#11421). Previously, AI metadata was stored in the root node's execution data, but with the new execution context changes, this data is now distributed across individual supply nodes.

Changes

  • Modified how we retrieve AI execution metadata by scanning connected supply nodes instead of relying on root node data
  • Updated tree node data collection to use workflow graph traversal instead of direct connection lookup
  • Fixed tree visualization to properly represent the execution hierarchy of AI nodes
  • Removed pagination from log view since it's not relevant for AI execution data

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 29, 2024
burivuhster
burivuhster previously approved these changes Oct 31, 2024
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 31, 2024

n8n    Run #7629

Run Properties:  status check passed Passed #7629  •  git commit 9af5389e4a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review ai-419-fix-ai-logs-not-appearing
Run status status check passed Passed #7629
Run duration 04m 28s
Commit git commit 9af5389e4a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

burivuhster
burivuhster previously approved these changes Oct 31, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 73b0a80 into master Oct 31, 2024
54 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-419-fix-ai-logs-not-appearing branch October 31, 2024 13:20
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants