Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Enable pinning main output with error and always allow unpinning #11452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Oct 29, 2024

Summary

Allow pinning the main output even if we have an error branch from the OnError setting.

Also always allow unpinning existing pinned data.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2343/community-issue-cant-unpin-output-in-http-module
#10066
#10240

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 29, 2024
@CharlieKolb CharlieKolb changed the title bug(editor): Enable pinning main output with error and always allow unpinning fix(editor): Enable pinning main output with error and always allow unpinning Oct 29, 2024
@CharlieKolb CharlieKolb marked this pull request as ready for review October 31, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant