fix(editor): When cloud users click on "How to update your n8n version" auto-login them before redirecting to the dashboard (no-changelog) #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them before redirecting to the dashboard
RicardoE105
changed the title
4 tasks
RicardoE105
changed the title
RicardoE105
changed the base branch from
master
to
move-updates-panel-to-composition
n8n-assistant
bot
added
n8n team
This helps consolidate all logic to redirect to owner to the cloud dashboard in one place, the uiStore.
RicardoE105
force-pushed
the
ado-2616-bug-when-cloud-users-click-on-update-info-url-they-dont-get-v2
branch
from
e41bace
to
abb68a6
Compare
mutdmour
reviewed
Oct 30, 2024
| @@ -628,6 +630,40 @@ export const useUIStore = defineStore(STORES.UI, () => { | |||
| lastCancelledConnectionPosition.value = undefined; | |||
| } | |||
|
|
|||
| const isInstanceOwnerInCloud = () => { | |||
There was a problem hiding this comment.
would this be a better fit in the cloud plans or users store?
because ui store is already too big and general, and is slowly getting broken apart.
| * cloud dashboard that redirects the user to the manage page where they can upgrade to a new n8n version. | ||
| * Otherwise, it redirect them to our docs. | ||
| */ | ||
| const goToVersions = async () => { |
There was a problem hiding this comment.
would this be a better fit in the versions store? maybe gotToUpgrade and generateUpgradeLink as well?
There was a problem hiding this comment.
moved all method that redirect into their own composable
| location.href = versionsLink; | ||
| }; | ||
|
|
||
| const goToDashboard = async () => { |
There was a problem hiding this comment.
would this be a better fir in the cloud plans store? maybe generateCloudDashboardAutoLoginLink as well?
…ate-info-url-they-dont-get-v2
mutdmour
previously approved these changes
Nov 1, 2024
| }; | ||
| }); | ||
|
|
||
| describe('usePageRedirectionHelper', () => { |
There was a problem hiding this comment.
thank you for adding all these tests
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ado-2616-bug-when-cloud-users-click-on-update-info-url-they-dont-get-v2
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Ricardo Espinoza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
mutdmour
approved these changes
Nov 1, 2024
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-2616-bug-when-cloud-users-click-on-update-info-url-they-dont-get-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Title self explanatory.
Builds on top of #11466
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2616/bug-when-cloud-users-click-on-update-info-url-they-dont-get-auto
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)