Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move page components to composables (no-changelog) #11494

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Nov 1, 2024

Summary

Move components to composables

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 1, 2024
@mutdmour mutdmour changed the title refactor: Move components to composables (no-changelog) refactor: Move page components to composables (no-changelog) Nov 1, 2024
@mutdmour mutdmour marked this pull request as ready for review November 1, 2024 11:47
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🙏

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 1, 2024

n8n    Run #7647

Run Properties:  status check passed Passed #7647  •  git commit 54417772c7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review composables-1
Run status status check passed Passed #7647
Run duration 04m 35s
Commit git commit 54417772c7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

@mutdmour mutdmour merged commit c773181 into master Nov 1, 2024
34 checks passed
@mutdmour mutdmour deleted the composables-1 branch November 1, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants