feat: continue_recursive_circuit api
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalinbhardwaj
requested changes
Aug 16, 2023
src/lib.rs
Outdated
| @@ -309,3 +309,106 @@ where | |||
|
|
|||
| Ok(recursive_snark) | |||
| } | |||
|
|
|||
| #[cfg(not(target_family = "wasm"))] | |||
| pub fn add_step<G1, G2>( | |||
There was a problem hiding this comment.
The current create_recursive_circuit API allows for multiple steps in one call. That’s partly because the cost of witness generation can be reduced by batching. Thoughts on making this API similar?
Maybe rename to continue_recursive_circuit and supporting list of private inputs. It may also be possible to refactor the existing code a bit then and prevent code dupe, but I can do that clean up later as well seperately. :)
enricobottazzi
changed the title
add_step apicontinue_recursive_circuit api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The featured API allows adding a further IVC step to a
RecursiveSnark. It is useful for any application in which all the steps are not known in advance.A few points:
zn_primaryfrom theRecursiveSnarkinstead of passing it as input to theadd_stepfunctioncircuit_secondaryandz0_secondaryactually are. Is it safe to instantiate them to 0/default within theadd_stepfunction or is there a case in which the user may want to set a different value?