Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetDevicePublicKey #2400

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add GetDevicePublicKey #2400

wants to merge 3 commits into from

Conversation

aromaa
Copy link
Contributor

@aromaa aromaa commented Jul 21, 2022 •
edited by josesimoes
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label Jul 21, 2022
@aromaa aromaa closed this Dec 13, 2022
@nfbot nfbot added invalid and removed Type: dependencies Pull requests that update a dependency file(s) or version labels Dec 13, 2022
@aromaa aromaa reopened this Dec 13, 2022
@aromaa
Copy link
Contributor Author

aromaa commented Dec 13, 2022

Okay, I somehow did something wrong while rebasing this to fix the force push conflict and messed up the whole commit history and lost my own while at it. sigh Anyways, fixed it.

@networkfusion
Copy link
Member

@aromaa Is this PR still valid given all the changes?

@aromaa
Copy link
Contributor Author

aromaa commented Sep 27, 2023

This needs a bit updating to stub the new platforms and a bit of updating. I'm planning to do that in the future as I will be needing to update my devices soon for the new Azure certificate so the branch will be up to date after that.

@aromaa
Copy link
Contributor Author

aromaa commented Oct 4, 2023

Actually there wasn't much else to do as the new platforms are already falling back to the existing stubs. Fixed few copy & paste mistakes. Still seems to work just fine on my ESP32.

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ellerbach Ellerbach Ellerbach left review comments

@josesimoes josesimoes josesimoes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Type: dependencies Pull requests that update a dependency file(s) or version Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aromaa @networkfusion @josesimoes @Ellerbach @nfbot