This repository has been archived by the owner on Jan 16, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
NTP peers #186
Open
tommarcoen
wants to merge
5
commits into
napalm-automation:develop
Choose a base branch
from
tommarcoen:ntp-peers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NTP peers #186
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
21f0e1c
Add: get_ntp_peers
c4f22df
PEP8 + test files
b9322fd
Remove VRF support from the model to remain consistent with other dri…
62faeb4
Revert mocked data for get_ntp_peers
mirceaulinic 1a4640c
Revert mocked data for get_ntp_servers
mirceaulinic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
test/unit/mocked_data/test_get_ntp_peers/normal/expected_result.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"2001:DB8:0:0:8:800:200C:417A": {}, | ||
"17.72.148.53": {}, | ||
"192.168.0.1": {}, | ||
"37.187.56.220": [{ | ||
"vrf": "NAPALM" | ||
}] | ||
} |
4 changes: 4 additions & 0 deletions
4
test/unit/mocked_data/test_get_ntp_peers/normal/show_run___include_ntp_peer.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
ntp peer 192.168.0.1 prefer | ||
ntp peer 17.72.148.53 | ||
ntp peer vrf NAPALM 37.187.56.220 | ||
ntp peer 2001:DB8:0:0:8:800:200C:417A version 4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,7 @@ | |
"2001:DB8:0:0:8:800:200C:417A": {}, | ||
"17.72.148.53": {}, | ||
"192.168.0.1": {}, | ||
"37.187.56.220": {} | ||
"37.187.56.220": [{ | ||
"vrf": "NAPALM" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
}] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t0mmetje to pass the tests, please remove this and let this peer have an empty dictionary as the other ones.