Skip to content
This repository has been archived by the owner on Jan 16, 2019. It is now read-only.

Fix IPv6 regex issue #202

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pierky
Copy link

@pierky pierky commented Sep 21, 2017

The current one seems that does not match addresses in the form 2001:DB8:A:100:1E1:B5E1:5169:96 (totally exploded, with some hextets made of 4 characters)

It was not matching addresses in the form
2001:DB8:A:100:1E1:B5E1:5169:96 (totally exploded, with some
hextets made of 4 characters)
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-0.08%) to 69.542% when pulling 4e8e083 on pierky:ipv6_regex into d2870e6 on napalm-automation:develop.

@ktbyers
Copy link
Contributor

ktbyers commented Sep 29, 2017

Thanks for flagging this. Let me check it.

@mirceaulinic mirceaulinic requested a review from a team October 6, 2017 23:52
@mirceaulinic mirceaulinic added this to the 0.8.1 milestone Oct 6, 2017
@ktbyers ktbyers requested review from ktbyers and removed request for a team October 7, 2017 14:59
@ktbyers ktbyers added the blocked label Oct 9, 2017
@ktbyers
Copy link
Contributor

ktbyers commented Oct 9, 2017

Waiting on napalm-base 0.26.0 to be released.

@ktbyers
Copy link
Contributor

ktbyers commented Oct 24, 2017

Will reimplement post reunification.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants