Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for nxos_ssh #2148

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

n-rodriguez
Copy link

Thank you!

…t is not associated with a value

Stacktrace:

  File "/data/apps/netbox/.asdf/installs/python/3.11.9/lib/python3.11/site-packages/napalm/nxos_ssh/nxos_ssh.py", line 511, in parse_uptime
    + seconds
      ^^^^^^^
@n-rodriguez
Copy link
Author

ping @bewing

Sometimes unit is "Kbit/sec":

  MTU 1500 bytes, BW 1000000 Kbit/sec, DLY 10 usec,
     reliability 255/255, txload 1/255, rxload 1/255
Copy link
Member

@bewing bewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! If you have time, it would be very helpful to the codebase to add a unit test for the staticmethod as noted

napalm/nxos_ssh/nxos_ssh.py Show resolved Hide resolved
@n-rodriguez
Copy link
Author

ping @bewing

Copy link
Member

@bewing bewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@bewing bewing merged commit d0d2a3e into napalm-automation:develop Oct 15, 2024
6 checks passed
@n-rodriguez
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants