Junos get_config patch #2150
Junos get_config patch #2150
Conversation
If no format attribute is specified get_config returns config as a plain text, but in json is specified, it returns a dict. Probably it still needs further polishing. e.g I cast it to a str, but maybe i could stay as dict. It's my first pull request ever, Sorry if I messed something up.
|
@SenorRodriguez Can you provide some more details on the problem you are trying to solve i.e. what use case you are running into issues and how Netmiko currently behaves in that use case? |
|
I was trying to write some code for validating get_config, when I noticed that getting JSON was also not possible (as mentioned in pull req comment) This was my attempt to fix that. Didn't even try netmiko yet. |
|
@SenorRodriguez Yeah, the Netmiko comment was just my mistake...I should have said |
|
I'm off my work PC, but in case I try to get a config in json format, napalm throws something like "config" dosn't have 'text' property", and sure enough - it returns dict instead of string |
If no format attribute is specified get_config returns config as a plain text, but in json is specified, it returns a dict.
Probably it still needs further polishing. e.g I cast it to a str, but maybe i could stay as dict. It's my first pull request ever, Sorry if I messed something up.