-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SK_SN binary conversion #41
base: main
Are you sure you want to change the base?
Conversation
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
Looks fine. I am unable to add me as reviewer of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collection_duration
energy_limit: shouldn't it be max energy?
Are these SK_SN wordings?
Yes, these are the SK_SN wording. There are fields in the text notices:
|
Binary conversion for Superkamiokande supernova mission. Added the following keywords not in the core schema: