Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SK_SN binary conversion #41

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

athish-thiru
Copy link
Contributor

@athish-thiru athish-thiru commented Aug 20, 2024

Binary conversion for Superkamiokande supernova mission. Added the following keywords not in the core schema:

  • n_events - The number of neutrinos detected.
  • ra_dec_error_68 - The localization error with 68% containment.
  • ra_dec_error_95 - The localization error with 95% containment.
  • collection_duration - Collection window for neutrinos.
  • energy_limit - minimum energy for neutrino.
  • distance_range - low, high energy limit for supernova distance

@Vidushi-GitHub
Copy link
Member

Looks fine. I am unable to add me as reviewer of this PR.

Copy link
Member

@Vidushi-GitHub Vidushi-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collection_duration
energy_limit: shouldn't it be max energy?

Are these SK_SN wordings?

@athish-thiru
Copy link
Contributor Author

athish-thiru commented Oct 13, 2024

collection_duration energy_limit: shouldn't it be max energy?

Are these SK_SN wordings?

Yes, these are the SK_SN wording. There are fields in the text notices:

ENERGY_LIMIT:     7.00 [MeV]  (Minimum energy of the neutrinos)
DURATION:         10.0 [sec]  (Collection duration of the neutrinos)
  • These two fields are not defined in the Packet Socket definition. I was mainly going of the description in the text notices, since the source code is not very descriptive either.
  • energy_limit does not specify max or min energy is the source code. It only says minimum energy in the text notice.
  • I used collection_duration to make the field more descriptive, but I could change it to just duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants