Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWIFT UVOT + General SWIFT Notices Binary Conversions #58

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

athish-thiru
Copy link
Contributor

@athish-thiru athish-thiru commented Nov 1, 2024

This PR includes the general SWIFT notices sent by all the instruments as well as all the notices sent by SWIFT UVOT. While skimming through the packet socket documentation, I noticed that SWIFT_UVOT_NACK_POS was a notice that continues to be produced but was not present in the repo. Added the following keywords not present in the core-schema:
SWIFT_ACTUAL_POINTDIR

  • bright_star_nearby

SWIFT_POINTDIR

  • bat_more, xrt_mode, uvot_mode
  • observation_time
  • merit_value
  • target_name

SWIFT_FOM_OBS, SWIFT_TOO_FOM

  • merit_value, sufficient_merit
  • point_source, flaring_known_source, star_tracker_status, bright_star_nearby, removed_from_catalog, galaxy_nearby
  • trigger_index
  • new_automated_target

SWIFT_SC_SLEW, SWIFT_TOO_SC_SLEW

  • wait_time, observation_time
  • point_source, flaring_known_source, star_tracker_status, bright_star_nearby, removed_from_catalog, galaxy_nearby
  • trigger_index
  • merit_value
  • slew_return_code
  • bat_mode, xrt_mode, uvot_mode

SWIFT_UVOT_DBURST, SWIFT_UVOT_DBURST_PROC

  • exposure_ID
  • image_offset, image_size
  • grb_position
  • n_frames
  • fits_file_url
  • pixel_binning
  • bright_star_nearby

SWIFT_UVOT_FCHART, SWIFT_UVOT_FCHART_PROC

  • background_mean
  • image_max, image_offset
  • n_stars
  • detector_threshold, photometry_threshold
  • fits_file_url

SWIFT_UVOT_POS

  • magnitude, magnitude_error
  • point_source, catalog_source, ground_catalog_source, spatial_coincidence, temporal_coincidence, bright_star_nearby, updated_position, ground_generated

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 94.36620% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (d285741) to head (ff4afa4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
..._classic_to_json/notices/SWIFT_FOM_OBS/__init__.py 87.09% 4 Missing ⚠️
..._classic_to_json/notices/SWIFT_SC_SLEW/__init__.py 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   75.94%   84.66%   +8.71%     
==========================================
  Files          10       21      +11     
  Lines         158      300     +142     
==========================================
+ Hits          120      254     +134     
- Misses         38       46       +8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added instrument modes

SWIFT UVOT binary conversion

small changes

more small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants