Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment to Node.js 22.x #2745

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Dec 3, 2024

No description provided.

@lpsinger lpsinger requested review from Courey and dakota002 December 3, 2024 02:15
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.22%. Comparing base (f80dd22) to head (659bb6d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2745   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files        167     167           
  Lines       4258    4258           
  Branches     472     472           
=====================================
  Hits         265     265           
  Misses      3991    3991           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dakota002
Copy link
Contributor

I don't believe this version is supported yet by architect

@lpsinger
Copy link
Member Author

lpsinger commented Dec 3, 2024

I don't believe this version is supported yet by architect

It's not? Why do you say so?

@dakota002
Copy link
Contributor

From trying it locally,
image

And their build matrix on github:
image

@lpsinger
Copy link
Member Author

lpsinger commented Dec 3, 2024

Blocked by architect/lambda-runtimes#8.

@lpsinger lpsinger added the blocked work is blocked label Dec 3, 2024
@lpsinger
Copy link
Member Author

lpsinger commented Dec 6, 2024

Blocked by architect/lambda-runtimes#8.

Blocked by #2494.

@lpsinger
Copy link
Member Author

lpsinger commented Dec 6, 2024

Blocked by #2494.

Ready to go now.

@lpsinger lpsinger removed the blocked work is blocked label Dec 6, 2024
@dakota002 dakota002 merged commit f034043 into nasa-gcn:main Dec 6, 2024
12 checks passed
@lpsinger lpsinger deleted the nodejs22 branch December 6, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants