-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #265, change variable names to be more informative #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
{ | ||
/* no more messages this wakeup allowed */ | ||
c->cur = t; /* remember where we were for next time */ | ||
success = false; | ||
chan->cur = txn; /* remember where we were for next time */ |
Check warning
Code scanning / CodeQL-security
Local variable address stored in non-local memory Warning
parameter
} | ||
|
||
/* don't need CF_CRC_Start() since taken care of by reset_cfdp() */ | ||
/*CF_CRC_Start(&t->crc);*/ | ||
/*CF_CRC_Start(&txn->crc);*/ |
Check notice
Code scanning / CodeQL
Commented-out code Note
043ce89
to
b0719e8
Compare
CCB 6 October 2022: Approved pending merge conflict resolution |
7521095
to
c840f27
Compare
c840f27
to
ea43036
Compare
76ad4ad
to
175f863
Compare
@@ -106,7 +106,7 @@ | |||
|
|||
if (!CF_AppData.engine.out.msg) | |||
{ | |||
c->cur = t; /* remember where we were for next time */ | |||
chan->cur = txn; /* remember where we were for next time */ |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
parameter
175f863
to
c2725b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@havencarlson -- This looked great, thanks for the effort in doing this. I added a new commit to the PR to fixup a few things I saw when reviewing. Mostly - I ran it through clang-format again to fixup some of the white space that got changed due to the difference in name length.
There were a couple other minor updates - There was one function that was still using "pt" as a transaction instead of "txn" so I made it consistent.
I just committed my updates as a second commit, please have a look at 157e04a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Checklist (Please check before submitting)
Describe the contribution
Fix #265, change single-letter variable names to be more descriptive
Testing performed
Unit testing
Expected behavior changes
no impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA