Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10134 Adding in the new subscription schema and setting the subscription cache when the ingest subscriptions are added or deleted. #2176

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

eereiter
Copy link
Contributor

Overview

What is the feature/fix?

Adding in the new subscription schema and setting the subscription cache when the ingest subscriptions are added or deleted.

What is the Solution?

Adding in the new subscription schema and setting the subscription cache when the ingest subscriptions are added or deleted.

What areas of the application does this impact?

Ingest, subscriptions, metadata_db

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 78 lines in your changes missing coverage. Please review.

Project coverage is 56.99%. Comparing base (a639272) to head (f488a19).

Files with missing lines Patch % Lines
ingest-app/src/cmr/ingest/api/subscriptions.clj 0.00% 61 Missing ⚠️
ingest-app/src/cmr/ingest/api/routes.clj 0.00% 5 Missing ⚠️
...mr/ingest/services/ingest_service/subscription.clj 0.00% 3 Missing ⚠️
...p/src/cmr/metadata_db/services/concept_service.clj 0.00% 2 Missing ⚠️
...app/src/cmr/metadata_db/services/subscriptions.clj 90.00% 0 Missing and 2 partials ⚠️
metadata-db-app/src/cmr/metadata_db/system.clj 0.00% 2 Missing ⚠️
...p/src/cmr/ingest/services/subscriptions_helper.clj 0.00% 1 Missing ⚠️
metadata-db-app/src/cmr/metadata_db/config.clj 50.00% 0 Missing and 1 partial ⚠️
...utils-lib/src/cmr/redis_utils/redis_hash_cache.clj 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
- Coverage   58.15%   56.99%   -1.17%     
==========================================
  Files        1045     1047       +2     
  Lines       70428    70480      +52     
  Branches     2001     1964      -37     
==========================================
- Hits        40959    40167     -792     
- Misses      27610    28481     +871     
+ Partials     1859     1832      -27     
Flag Coverage Δ
56.99% <40.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eereiter eereiter merged commit 53f7115 into master Sep 28, 2024
6 checks passed
@eereiter eereiter deleted the CMR-10134 branch September 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants