Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2595, Use string append and add newline #2596

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

pepepr08
Copy link
Contributor

@pepepr08 pepepr08 commented Aug 16, 2024

...to avoid using list, which appends an undesired semicolon that causes build errors when compiling multiple targets for multiple platforms at the same time

Checklist (Please check before submitting)

Describe the contribution
Fixes #2595

Testing performed
Steps taken to test the contribution:

  1. Follow same steps to reproduce the error as described in issue
  2. FSW successfully compiles now

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Project Pipeline runs

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza | NASA GSFC

to avoid using list, which appends an undesired semicolon
@pepepr08 pepepr08 marked this pull request as ready for review August 16, 2024 20:39
@pepepr08 pepepr08 requested a review from jphickey August 16, 2024 20:39
@pepepr08 pepepr08 self-assigned this Aug 16, 2024
@pepepr08 pepepr08 added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 16, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 22, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 29, 2024
*Combines:*

cFE equuleus-rc1+dev195
**Includes:**

*cFE*
- nasa/cFE#2596
- nasa/cFE#2593

Co-authored by: Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker merged commit 023f29f into nasa:main Aug 29, 2024
21 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 29, 2024
*Combines:*

cFE equuleus-rc1+dev195
**Includes:**

*cFE*
- nasa/cFE#2596
- nasa/cFE#2593

Co-authored by: Jose Martinez Pedraza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error when compiling for multiple targets platforms
2 participants