Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update package lock to reference correct version of package and also update the browserlist #7843

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Sep 13, 2024

Partially addresses #7828

Describe your changes:

We cannot modify the package.json directly without running npm install in our release process @ozyx
Additionally, I'm wearing adding the npx browserlist update command to our build process outside of a release automation step. I've run it once in this PR to clear it.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Sep 13, 2024
@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.80%. Comparing base (26578e8) to head (ca2b9f7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7843      +/-   ##
==========================================
- Coverage   59.10%   58.80%   -0.31%     
==========================================
  Files         675      675              
  Lines       27284    27284              
  Branches     2671     2671              
==========================================
- Hits        16126    16044      -82     
- Misses      11110    11192      +82     
  Partials       48       48              
Flag Coverage Δ
e2e-ci 61.78% <ø> (ø)
e2e-full 23.51% <ø> (-18.42%) ⬇️
unit 51.18% <ø> (-0.05%) ⬇️

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26578e8...ca2b9f7. Read the comment docs.

@ozyx ozyx self-requested a review September 13, 2024 14:37
@unlikelyzero unlikelyzero force-pushed the update-missing-package-lock-changes branch from 766a60b to ca2b9f7 Compare September 13, 2024 14:51
@unlikelyzero unlikelyzero merged commit fa8efa8 into master Sep 13, 2024
34 of 40 checks passed
@unlikelyzero unlikelyzero deleted the update-missing-package-lock-changes branch September 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants