Feature/email headers kbs319 #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 6, 2021 17:01
…uple the AWS sending implementation from the main email service.
added 6 commits
September 7, 2021 13:19
… specified in and read from appsettings.json configuration file.
…psettings.json without throwing an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now use raw email to send via AWS API. This allows us to add additional headers for use with CloudTrail. i.e.
X-SES-CONFIGURATION-SET: KBSEmailsToDSD
X-SES-MESSAGE-TAGS: booking-confirmation=adv-order
Also, the code to send the email has been refactored into an interface and AWS specific implementation for raw email, to remove the direct dependency in the EmailService and allow for alternative implementations.