Fcl 90 Use codes not params in search. #1377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
changed the title
dragon-dxw
force-pushed
the
FCL-90-move-to-codes-not-params
branch
from
2816241
to
9310458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to move to court codes as they're more stable etc. (
EWHC-Chancery-IPEC)But quite a lot of moving parts assume parameters (
ewhc/ipec)Currently incomplete
all these tests with ewhc/ch etc aren't testing the right thing.
We also need to make sure that edge cases like the QB/KB work
We also need to make sure Marklogic is updated to have the correct behaviour
Should we support old search URLs too?
The search form raises an error for ewhc/ch now, but doesn't highlight where (because there is nowhere)
some routes still use params internally -- get_court_crest_path, get_court_intro_text, get_court_date_range
many test_search tests still testing parameters not codes.
Changes in this PR:
Jira card / Rollbar error (etc)
https://national-archives.atlassian.net/browse/FCL-90
Screenshots of UI changes:
Before
After