Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup http4s server #2

Merged
merged 13 commits into from
Jul 8, 2024
Merged

Setup http4s server #2

merged 13 commits into from
Jul 8, 2024

Conversation

TomJKing
Copy link
Contributor

No description provided.

Copy link
Contributor

@vimleshtna vimleshtna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor comments. Thanks
I see the readme.md file is not updated but since it is just a prototype you can update it later.

@TomJKing TomJKing requested a review from vimleshtna July 8, 2024 12:26
Copy link
Contributor

@vimleshtna vimleshtna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@TomJKing TomJKing merged commit 7c9e9cd into main Jul 8, 2024
3 checks passed
@TomJKing TomJKing deleted the setup-http4s-server branch July 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants