Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete site #62

Merged
merged 2 commits into from
Apr 25, 2023
Merged

feat: delete site #62

merged 2 commits into from
Apr 25, 2023

Conversation

andriacap
Copy link

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

mvergez
mvergez suggested changes Apr 20, 2023
View reviewed changes
Copy link

@mvergez mvergez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup ! J'ai juste un petit changement si ça t'embête pas
Et il faudrait ajouter un petit test aussi, mais bon si pas le temps, pas grave !

backend/gn_module_monitoring/routes/site.py Outdated Show resolved Hide resolved
@andriacap
Copy link
Author

Test mis en place :)

@andriacap
feat: delete site
9b17a2f 
Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
@andriacap
test: add test for delete item site
0b2f1bc 
Reviewed-by: andriac
[Refs_ticket]: #5 , #6
@mvergez mvergez merged commit 85f59fd into dev-suivi-eolien Apr 25, 2023
@mvergez mvergez deleted the feat/delete-site branch April 25, 2023 14:57
andriacap added a commit that referenced this pull request Jul 19, 2023
@andriacap
feat: delete site (#62)
3e49fdc 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Jul 28, 2023
@andriacap
feat: delete site (#62)
255017b 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Aug 22, 2023
@andriacap
feat: delete site (#62)
12f9b49 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Aug 23, 2023
@andriacap
feat: delete site (#62)
7b9497a 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Sep 1, 2023
@andriacap
feat: delete site (#62)
199e1c3 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Sep 7, 2023
@andriacap
feat: delete site (#62)
0a09f18 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
amandine-sahl pushed a commit that referenced this pull request Oct 5, 2023
@andriacap @amandine-sahl
feat: delete site (#62)
e2b944b 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
amandine-sahl pushed a commit that referenced this pull request Oct 10, 2023
@andriacap @amandine-sahl
feat: delete site (#62)
1d8a442 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
amandine-sahl pushed a commit that referenced this pull request Oct 10, 2023
@andriacap @amandine-sahl
feat: delete site (#62)
7375ab0 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
andriacap added a commit that referenced this pull request Feb 12, 2024
@andriacap @amandine-sahl
feat: delete site (#62)
43c6d49 
* feat: delete site

Add code from backend to delete site (frontend is already implemented)

Reviewed-by: andriac
[Refs_ticket]: #5 , #6

* test: add test for delete item site

Reviewed-by: andriac
[Refs_ticket]: #5 , #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvergez mvergez mvergez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andriacap @mvergez