-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature delices v2 #146
Merged
Merged
Feature delices v2 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements views for: - design - design instance - journal - journal entry
Changed type hinting to indicate that django.db.models.Model is truly the base class of what we are dealing with in terms of model instances
A similar tag is provided out of the box with the Jinja2 framework so we aren't going to carry forward the `indent` support in Design Builder.
This provides some unit tests for the commit and roll back functionality provided by `ext.Extension`. This commit also introduces a small fix for the `commit` behavior.
abates
force-pushed
the
feature_delices_v2
branch
from
June 3, 2024 12:19
1d6f57b
to
8bcb07c
Compare
* tests: add a test to make sure that a failed deployment is not created * fix: rollback the whole changes in a Design Job if something fails
abates
force-pushed
the
feature_delices_v2
branch
from
June 26, 2024 11:49
14f49fb
to
0cbe6e6
Compare
abates
force-pushed
the
feature_delices_v2
branch
from
August 15, 2024 00:40
e60c577
to
55355f7
Compare
abates
force-pushed
the
feature_delices_v2
branch
2 times, most recently
from
October 1, 2024 18:47
65b557c
to
c15ea21
Compare
abates
force-pushed
the
feature_delices_v2
branch
from
October 2, 2024 15:19
c15ea21
to
1d265f2
Compare
chadell
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to unit test designs using YAML test syntaxTracked by Provide design testing capabilities #26Convert device lifecycle testing to YAML test syntaxTracked by Low Code testing strategy for designs #168Docs review and cleanupTracked by Review documentation #176