Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature delices v2 #146

Merged
merged 150 commits into from
Oct 4, 2024
Merged

Feature delices v2 #146

merged 150 commits into from
Oct 4, 2024

Conversation

abates
Copy link
Contributor

@abates abates commented May 8, 2024

abates and others added 30 commits July 28, 2023 14:53
Implements views for:
- design
- design instance
- journal
- journal entry
Changed type hinting to indicate that django.db.models.Model is truly the base class of what we are dealing with in terms of model instances
A similar tag is provided out of the box with the Jinja2 framework so we aren't going to carry forward the `indent` support in Design Builder.
This provides some unit tests for the commit and roll back functionality provided by `ext.Extension`. This commit also introduces a small fix for the `commit` behavior.
@abates abates marked this pull request as ready for review June 26, 2024 11:50
@abates abates requested a review from mzbroch as a code owner June 26, 2024 11:50
@abates abates force-pushed the feature_delices_v2 branch 2 times, most recently from 65b557c to c15ea21 Compare October 1, 2024 18:47
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abates abates merged commit fc775ea into develop Oct 4, 2024
15 checks passed
@abates abates deleted the feature_delices_v2 branch October 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants