Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed signal issues #58

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix: Fixed signal issues #58

merged 3 commits into from
Jul 31, 2023

Conversation

abates
Copy link
Contributor

@abates abates commented Jul 27, 2023

This is an attempt to troubleshoot weird signal behavior in the CI pipeline that is not reliably reproduced locally.

This is an attempt to troubleshoot weird signal behavior in the CI pipeline that is not reliably reproduced locally.
@abates abates requested a review from mzbroch as a code owner July 27, 2023 17:18
mzbroch
mzbroch previously approved these changes Jul 28, 2023
@mzbroch
Copy link

mzbroch commented Jul 31, 2023

I think we might be getting too complex here and we should improve modelling inside the bgp itself, shouldn't we ?

@abates
Copy link
Contributor Author

abates commented Jul 31, 2023

I'm a little undecided about whether or not this functionality is too complex. There are clearly cases where we need to do something after an object has been saved. This is due to the fact that Nautobot commonly has business logic in the controller layer rather than the model layer. Specifically with BGP models we could move the peering updates to either the clean method or the save method in the model and it would solve this specific use case.

In the bigger picture, however, the question is: do we need to supply lifecycle hooks to action tags to handle these types of complex use cases?

@abates abates marked this pull request as draft July 31, 2023 10:51
@abates abates marked this pull request as ready for review July 31, 2023 11:09
@abates abates force-pushed the signal_fix branch 2 times, most recently from e443c04 to 8dfc757 Compare July 31, 2023 11:56
@abates abates changed the title refactor: Moved signals out of class fix: Fixed signal issues Jul 31, 2023
@abates abates merged commit 336f9b2 into develop Jul 31, 2023
14 checks passed
@abates abates deleted the signal_fix branch July 31, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants