Views #64
Merged
Views #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
force-pushed
the
lk-feature_delices
branch
3 times, most recently
from
237e50e
to
02e78c4
Compare
|
CI is (also) failing because of the failing CI of #59 |
Kircheneer
force-pushed
the
lk-feature_delices
branch
2 times, most recently
from
0e456f8
to
459216c
Compare
Kircheneer
commented
Aug 8, 2023
| @@ -13,7 +13,7 @@ | |||
| from design_builder.base import DesignJob | |||
| from design_builder.util import nautobot_version | |||
|
|
|||
| logging.disable(logging.CRITICAL) | |||
There was a problem hiding this comment.
@abates does this need to stay in? It's been causing problems with one of the UI view test cases
There was a problem hiding this comment.
I think I put this in because otherwise the tests generate a ton of logging output that isn't suppressed by the unit test framework. If you take it out do the tests run without a ton of output?
There was a problem hiding this comment.
Tests are silent for me even without this 🤷🏻
Kircheneer
force-pushed
the
lk-feature_delices
branch
2 times, most recently
from
041b5d8
to
2b4bb07
Compare
Implements views for: - design - design instance - journal - journal entry
Kircheneer
force-pushed
the
lk-feature_delices
branch
from
2b4bb07
to
bf7b974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds views for the newly introduced models.