-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views #64
Views #64
Conversation
237e50e
to
02e78c4
Compare
CI is (also) failing because of the failing CI of #59 |
0e456f8
to
459216c
Compare
@@ -13,7 +13,7 @@ | |||
from design_builder.base import DesignJob | |||
from design_builder.util import nautobot_version | |||
|
|||
logging.disable(logging.CRITICAL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abates does this need to stay in? It's been causing problems with one of the UI view test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I put this in because otherwise the tests generate a ton of logging output that isn't suppressed by the unit test framework. If you take it out do the tests run without a ton of output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are silent for me even without this 🤷🏻
041b5d8
to
2b4bb07
Compare
Implements views for: - design - design instance - journal - journal entry
2b4bb07
to
bf7b974
Compare
Adds views for the newly introduced models.