Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upstream Testing #383

Merged
merged 15 commits into from
Oct 18, 2024
Merged

Fix Upstream Testing #383

merged 15 commits into from
Oct 18, 2024

Conversation

smk4664
Copy link
Contributor

@smk4664 smk4664 commented Oct 17, 2024

By removing the config option for makemigrations.

This also brings the app up to the LTM 1.6 Cookiecutter standard and resolves an issue with Griffe being unable to generate the docs for the serializers.

By removing the config option for makemigrations.
@smk4664 smk4664 marked this pull request as draft October 17, 2024 21:57
The *serializer_base_classes does not work with Griffe
@smk4664 smk4664 marked this pull request as ready for review October 17, 2024 22:16
Copy link
Contributor

@gsnider2195 gsnider2195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You weren't kidding about this getting out of hand!

@smk4664 smk4664 merged commit 178264b into ltm-1.6 Oct 18, 2024
16 checks passed
@smk4664 smk4664 deleted the u/smk4664-fix-upstream-testing branch October 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants