Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Jinja Error Handling and Stack Trace Logging #149

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

jmpettit
Copy link
Contributor

@jmpettit jmpettit commented Mar 21, 2024

Screenshot 2024-03-21 at 12 21 53 PM

@jvanderaa
Copy link
Contributor

@jmpettit can we right a quick few unit tests on the helpers on this one?

@itdependsnetworks it would be great if we think we may at some point get some unit tests on the rest of the Nornir pieces as well. Not holding this one up for it.

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - check the commentary about the tests, we can probably go with this one without, but it would be good to help prevent any regressions.

@jeffkala
Copy link
Contributor

Introducing some new Exxx codes here, please update the actual docs under /task/troubleshooting/Exxx.

@jvanderaa jvanderaa merged commit 6c36c54 into develop Mar 29, 2024
26 checks passed
@jmpettit jmpettit deleted the jmpettit-jinja-logging branch April 16, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants