-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Jinja Error Handling and Stack Trace Logging #149
Conversation
jmpettit
commented
Mar 21, 2024
•
edited
Loading
edited
@jmpettit can we right a quick few unit tests on the helpers on this one? @itdependsnetworks it would be great if we think we may at some point get some unit tests on the rest of the Nornir pieces as well. Not holding this one up for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - check the commentary about the tests, we can probably go with this one without, but it would be good to help prevent any regressions.
Introducing some new Exxx codes here, please update the actual docs under |