Skip to content

Commit

Permalink
Fix bug in Channel.firstClosingFee
Browse files Browse the repository at this point in the history
* when estimating fee for first closing tx, it was creating
  WitScript by `Scirpt(ourWitnesses).ToWitScript()` which was trying to
  deserialize script from literal sequence of bytes instead of treating
  ourWitnesses as a data which has to get pushed into stack as a wintess
  item, thus causing argument exception in `ToWitScript()`
  • Loading branch information
joemphilips committed Jun 11, 2020
1 parent 50dce21 commit 6a284cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/DotNetLightning.Core/Channel/Channel.fs
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ module Channel =
let! dummyClosingTx = Transactions.makeClosingTx cm.FundingScriptCoin localSpk remoteSpk cm.LocalParams.IsFunder Money.Zero Money.Zero cm.LocalCommit.Spec n
let tx = dummyClosingTx.Value.GetGlobalTransaction()
tx.Inputs.[0].WitScript <-
let witness = seq [ dummySig.ToBytes(); dummySig.ToBytes(); dummyClosingTx.Value.Inputs.[0].WitnessScript.ToBytes() ] |> Array.concat
Script(witness).ToWitScript()
let witness = seq [ dummySig.ToBytes(); dummySig.ToBytes(); dummyClosingTx.Value.Inputs.[0].WitnessScript.ToBytes() ]
WitScript(witness)
let feeRatePerKw = FeeRatePerKw.Max (feeEst.GetEstSatPer1000Weight(ConfirmationTarget.HighPriority), cm.LocalCommit.Spec.FeeRatePerKw)
let vsize = tx.GetVirtualSize()
return feeRatePerKw.ToFee(uint64 vsize)
Expand Down

0 comments on commit 6a284cb

Please sign in to comment.