Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $LEGACY_REST_URL environment variable and associated code #276

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Remove $LEGACY_REST_URL environment variable and associated code #276

merged 2 commits into from
Jul 26, 2023

Conversation

jvendetti
Copy link
Member

  • Removes the unused $LEGACY_REST_URL environment variable (resolves deprecate LEGACY_REST_URL variable #211)
  • Removes the unused jsonp method, which referenced $LEGACY_REST_URL
  • Fixes some RuboCop warnings in AjaxProxyController

@jvendetti jvendetti self-assigned this Jul 26, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 26, 2023
View reviewed changes
app/controllers/ajax_proxy_controller.rb
@@ -83,7 +59,6 @@
json
end
end
render({plain: response, content_type: "application/json"}.merge(options))
render({ plain: response, content_type: 'application/json' }.merge(options))

Check notice

Code scanning / Brakeman

Render path contains parameter value. Note

Render path contains parameter value.
@jvendetti jvendetti merged commit c087005 into master Jul 26, 2023
2 checks passed
@jvendetti jvendetti deleted the refactor/legacy-rest-url/211 branch September 15, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jvendetti jvendetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate LEGACY_REST_URL variable
1 participant
@jvendetti