Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #173

Merged
merged 26 commits into from
Sep 15, 2023
Merged

Refactor #173

merged 26 commits into from
Sep 15, 2023

Conversation

ChrisJones687
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 65.49% and project coverage change: -3.32% ⚠️

Comparison is base (21e0f5f) 85.48% compared to head (231088b) 82.17%.
Report is 1 commits behind head on main.

❗ Current head 231088b differs from pull request most recent head e3698a1. Consider uploading reports for the commit e3698a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   85.48%   82.17%   -3.32%     
==========================================
  Files          46       51       +5     
  Lines        5396     5560     +164     
==========================================
- Hits         4613     4569      -44     
- Misses        783      991     +208     
Files Changed Coverage Δ
R/quantity_allocation_disagreement.R 87.84% <0.00%> (-3.22%) ⬇️
inst/include/PoPS_RcppExports.h 0.00% <ø> (ø)
inst/include/date.hpp 88.65% <0.00%> (-0.64%) ⬇️
...lude/normal_distribution_with_uniform_fallback.hpp 0.00% <0.00%> (ø)
inst/include/soils.hpp 0.00% <0.00%> (ø)
inst/include/environment.hpp 32.25% <32.25%> (ø)
inst/include/generator_provider.hpp 34.82% <34.82%> (ø)
R/configuration.R 80.63% <46.08%> (-11.47%) ⬇️
inst/include/config.hpp 65.51% <60.00%> (-0.53%) ⬇️
inst/include/quarantine.hpp 74.19% <71.42%> (-7.06%) ⬇️
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisJones687 ChrisJones687 marked this pull request as ready for review September 14, 2023 13:08
@ChrisJones687
Copy link
Member Author

ChrisJones687 commented Sep 15, 2023

Fixes #170, Fixes #158, and Fixes #135.

@ChrisJones687 ChrisJones687 merged commit e524e2c into main Sep 15, 2023
4 of 5 checks passed
@ChrisJones687 ChrisJones687 deleted the refactor branch September 15, 2023 20:35
@ChrisJones687
Copy link
Member Author

Closes #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant