Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added info about new status codes #2195

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

frolvanya
Copy link
Contributor

This PR is adding an information about new possible status codes that can be returned by jsonrpc

From now on, jsonrpc will start returning other HTTP codes than 200 OK for some errors:

  • On internal server error it will return 500
  • On timeout error it will return 408
  • On request validation error will return 400

Changes were introduced in near/nearcore#11806 and near/nearcore#11822

@frolvanya
Copy link
Contributor Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Aug 5, 2024

@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@khorolets 1

Your contribution is much appreciated with a final score of 1!
You have received 25 (10 base + 15 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @frolvanya! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I realize it might be a bit uncomfortable to scroll the table horizontally, but all the information is here and consumable. Designing the docs is a different sort of task.

@race-of-sloths score 1

Copy link
Contributor

@telezhnaya telezhnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the point that designing the doc is a separate job

LGTM

@bucanero bucanero merged commit 2709161 into near:master Aug 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

5 participants