Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Ethereum wallets modal after tx error within a batch. #1151

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

paouvrard
Copy link
Member

@paouvrard paouvrard commented Jul 29, 2024

Description

Hide the Ethereum wallets modal after a transaction error within a batch. Currently it lets the user sign the next transaction in the batch even though the App handles the rejected signAndSendTransactions() promise.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.

@paouvrard paouvrard changed the title fix: Hide modal after tx error within a batch. fix: Hide Ethereum wallets modal after tx error within a batch. Jul 29, 2024
Copy link
Collaborator

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@pivanov pivanov merged commit 3054c66 into near:dev Aug 2, 2024
13 checks passed
@pivanov pivanov mentioned this pull request Aug 2, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

2 participants