Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the new toggle functionality #1152

Merged
merged 2 commits into from
Aug 2, 2024
Merged

feat: add the new toggle functionality #1152

merged 2 commits into from
Aug 2, 2024

Conversation

pivanov
Copy link
Collaborator

@pivanov pivanov commented Jul 29, 2024 •
edited
Loading

Description

Implement Previous selected Wallet
Video

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title feat:add the new toggle functionality feat: add the new toggle functionality Jul 29, 2024
@pivanov pivanov requested a review from gtsonevv July 29, 2024 08:18
gtsonevv
gtsonevv previously approved these changes Jul 29, 2024
View reviewed changes
@pivanov pivanov requested a review from trechriron July 29, 2024 09:04
@trechriron
Copy link
Collaborator

The music over the video was a nice touch!

trechriron
trechriron previously requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more spacing between the Recent and other wallets. Otherwise, this is amazing!

@pivanov
Copy link
Collaborator Author

pivanov commented Aug 1, 2024

Please provide more spacing between the Recent and other wallets. Otherwise, this is amazing!

Hey @trechriron

Here is the improved version :)
Video

What do you think?

@pivanov pivanov enabled auto-merge August 2, 2024 07:11
@pivanov pivanov requested a review from gtsonevv August 2, 2024 07:12
pivanov
pivanov commented Aug 2, 2024
View reviewed changes
Copy link
Collaborator Author

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@pivanov pivanov merged commit e9fad88 into near:dev Aug 2, 2024
9 checks passed
@pivanov pivanov mentioned this pull request Aug 2, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsonevv gtsonevv gtsonevv approved these changes

@trechriron trechriron Awaiting requested review from trechriron

Assignees
No one assigned
Labels
None yet
Projects
NEAR DevX
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pivanov @trechriron @gtsonevv @dim-daskalov