Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Jupyter Scheduler integration #335

Merged
merged 5 commits into from
Jul 22, 2023
Merged

Docs for Jupyter Scheduler integration #335

merged 5 commits into from
Jul 22, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

These are docs for the new Jupyter-Scheduler integration, see nebari-dev/nebari#1832

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 3b12daa
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/64bb406245636c00089d0367
😎 Deploy Preview https://deploy-preview-335--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iameskild iameskild added area: integration/Jupyterlab content: doc/tutorial Diataxis - tutorial needs: review 👀 This PR is complete and ready for reviewing labels Jun 19, 2023
yarn.lock Outdated Show resolved Hide resolved
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iameskild! Just have two minor comments and everything else looks great, so approving. Please feel free self-merge when ready :)

@pavithraes pavithraes added needs: changes 🧱 Review completed - some changes are needed before merging status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Jun 19, 2023
@pavithraes pavithraes added status: blocked ⛔️ This item is on hold due to another task and removed needs: changes 🧱 Review completed - some changes are needed before merging labels Jun 20, 2023
@pavithraes
Copy link
Member

This PR will be merged with nebari-dev/nebari#1832

@iameskild iameskild removed the status: blocked ⛔️ This item is on hold due to another task label Jul 22, 2023
@iameskild iameskild merged commit 283c359 into main Jul 22, 2023
5 checks passed
@iameskild iameskild deleted the jupyter-scheduler branch July 22, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Jupyterlab content: doc/tutorial Diataxis - tutorial status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants