Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain for testing setup #498

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asmacdo
Copy link

@asmacdo asmacdo commented Aug 7, 2024

Builds on #496 to avoid merge conflicts. If you prefer, we could just merge this one and close the other.

Related: nebari-dev/nebari#2555

Thanks @vinicusdc for the suggestion nebari-dev/nebari#2555 (comment)

What does this implement/fix?

The local deployment docs include setting domain, which doesn't work out of the box without setting up DNS, which I've also added a link to.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Any other comments?

Local deployment with kind seems like the entrypoint for prospective users. Making this doc work smoothly out-of-the-box should be helpful I hope :)

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit ee55461
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/66f589eda35e3d00089e86c3
😎 Deploy Preview https://deploy-preview-498--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asmacdo
Copy link
Author

asmacdo commented Aug 8, 2024

@viniciusdc thanks for the review, it feels less clunky now. Let me know if theres anything else :)

@viniciusdc
Copy link
Contributor

Nice @asmacdo thanks, I will have another look later today 🚀

@viniciusdc
Copy link
Contributor

Hi @asmacdo sorry for the delay on this, got a busy ending of August. I plan on taking another look at this during this week. I noticed that there seems to be a conflict with some files above, if you had the time can you fix these? Otherwise, if you don't mind I can amend those as well.

docs/docs/how-tos/nebari-local.md Outdated Show resolved Hide resolved
docs/docs/how-tos/nebari-local.md Outdated Show resolved Hide resolved
@asmacdo
Copy link
Author

asmacdo commented Sep 26, 2024

I clumsily combined GH suggestions with local pushes, sorry for the awkwardness, I think its correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📬
Development

Successfully merging this pull request may close these issues.

2 participants