Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: supplement entity direct query function #322

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

n3A87
Copy link
Contributor

@n3A87 n3A87 commented Nov 3, 2024

No description provided.

@wey-gu wey-gu requested a review from CorvusYe November 3, 2024 11:19
Copy link
Collaborator

@CorvusYe CorvusYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very complete, I like it.

And, because this is a major usage upgrade, I would like to set the next version number as v2.0.0.

Before that, the previous PR may have some coding style issues that need to be noted.
I'm not sure if Tab indentation issues like this will be rejected.. For example: https://github.com/nebula-contrib/ngbatis/blob/0e417f0ac72b640733fb5bf267105bb01971ec27/src/main/java/org/nebula/contrib/ngbatis/base/GraphBaseExt.java#L42C1-L42C2

LGTM.

@@ -6,7 +6,8 @@ Ngbatis provides two ways for developers to access nebula.

- Close to Mybatis-plus, providing a basic `DAO` to be extends, unnecessary to write any `nGQL` to operate single table, include vertex and edge. (See [By Basic DAO](./dao-basic) for more details)
- Close to Mybatis, supporting developers to write complex `nGQL` or `Cypher` to finish read or write data. (See [By Custom nGQL](./custom-crud) for more details)

- Based on entity objects, directly call the provided query method to complete direct data inspection. (See [Entity Direct Query](./entity-query.md) for details. You can skip the following preparations using this method)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, please also pay attention to a small detail.

## Necessary `POJO` for two ways'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Thanks!I learn that and will change it later.

@CorvusYe CorvusYe merged commit d7ab9b5 into nebula-contrib:master Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants