-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix
] namespace scopes
#3503
base: master
Are you sure you want to change the base?
[Fix
] namespace scopes
#3503
Conversation
emmmmm, i definately love this, but many unrelated change right? that part i dont like~~~~ |
We agreed a while back that we wouldn't use |
Is not better the other one? Now is the default I think |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that we are moving from A to B and from B to A
I don't know what a or b is. We're just removing the file scoped namespacing. So all the code syntax is the same layout. I don't know who to blame (I guess I could look). But somebody allowed file scoped namespacing to be committed to the repo I was surprised to see how many was there. |
Change Log
file_scoped
toblock_scoped
for some files..editorconfig
to error on future namespacefile_scoped
files.dotnet format
on repo to fix any other problems.Example of Scoped file changes
file_scoped
block_scoped
Type of change
How Has This Been Tested?
Checklist: