Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use python 3.10 in GH actions #224

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

Tiboris
Copy link
Member

@Tiboris Tiboris commented Dec 1, 2022

Using latest python will help us to identify
latest changes and regressions early in upstream PRs. Bumped repo versions in .pre-commit-config.yaml
to point to latest stable releases per available check.

Signed-off-by: Tibor Dudlák [email protected]

@Tiboris Tiboris added trivial Trivial change test Test code or test requirement labels Dec 1, 2022
@dav-pascual dav-pascual self-requested a review December 1, 2022 11:25
@Tiboris Tiboris marked this pull request as draft December 1, 2022 11:40
@Tiboris
Copy link
Member Author

Tiboris commented Dec 1, 2022

marking as draft unless pre-commit hook erros are adressed

@Tiboris
Copy link
Member Author

Tiboris commented Dec 1, 2022

Seems like pylint does not support 3.11 yet.
pylint-dev/pylint#6535

We need to first fix some pylint isses before
changing checks python version to 3.10.
pylint has still some issues with Python 3.11

Signed-off-by: Tibor Dudlák <[email protected]>
Using latest python will help us to identify
latest changes and regressions early in upstream PRs.
Bumped repo versions in .pre-commit-config.yaml
to point to latest stable releases per available check.

Signed-off-by: Tibor Dudlák <[email protected]>
@Tiboris
Copy link
Member Author

Tiboris commented Dec 1, 2022

Decided to move to py3.10 unless 3.11 is usable for us without hax. Renaming the PR to reflect the changes here.

@Tiboris Tiboris marked this pull request as ready for review December 1, 2022 12:30
@Tiboris Tiboris changed the title chore: Use python 3.11 in GH actions chore: Use python 3.10 in GH actions Dec 1, 2022
@Tiboris Tiboris marked this pull request as draft December 1, 2022 12:31
@Tiboris Tiboris marked this pull request as ready for review December 1, 2022 12:31
@dav-pascual
Copy link
Member

LGTM, thanks @Tiboris !

@Tiboris Tiboris merged commit 3397948 into neoave:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test code or test requirement trivial Trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants