New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connection): remove unnecessary `format!` #112

Open

melotic wants to merge 1 commit into neonmoe:master from melotic:melotic/remove-format-connect

+3 −2

melotic commented Nov 11, 2024

We can use the .to_socket_addrs() on a &str and u16 and do not need to format it to {ip}:{port}.

The Connection:Connect method currently takes up 3.6 KiB:

 4.2%   6.5%  3.6KiB    minreq minreq::connection::Connection::connect

after:

 2.9%   4.5%  2.4KiB    minreq minreq::connection::Connection::connect


          fix(connection): remove unnecessary format!

f67a305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet