fix(fennel-ls): use cwd when git repo parent is not found #3389
Conversation
Previously when using `fennel-ls`, the LSP would fail to load if no parent was a Git repository and if a relative `flsproject.fnl` was not found. Now when using `fennel-ls`, the `root_dir` configuration option is set to the current working directory as a fallback when all other possible directories are not available.
| @@ -8,7 +8,7 @@ return { | |||
| local has_fls_project_cfg = function(path) | |||
| return util.path.is_file(vim.fs.joinpath(path, 'flsproject.fnl')) | |||
| end | |||
| return util.search_ancestors(dir, has_fls_project_cfg) or vim.fs.root(0, '.git') | |||
| return util.search_ancestors(dir, has_fls_project_cfg) or vim.fs.root(0, '.git') or vim.fn.getcwd() | |||
There was a problem hiding this comment.
use vim.uv.cwd() would be better.
|
Isn't this something that could be done by default? But IIRC that was discussed and there were reasons against it. I can't find the discussion though. Why is this reasonable for e.g. fennel and pyright, but not others? |
At least from core perspective And afaik a |
|
Thanks for those reminders!
Right, and then this PR reintroduces that issue... |
Context
For the
fennel-lslspconfig, I recently changed how thefennel-lsconfiguration file is found, i.e. nearest config -> git root.However, when there is no
fennel-lsconfiguration available, and all parent directories of the current buffer do contain git repositories, then the LSP won't be loaded at all. This PR fixes that.Changes
cwdforfennel-lswhen git repository parent is unavailableQuestions
root_dirisnil, should the LSP fail to load? I'm not sure if there are legitimate cases to ever sendnilto an LSP but I thought I'd ask if a wider, structural solution is appropriate.Thanks for your help!