Fix running api server locally #38
Conversation
efiacor
requested review from
electrocucaracha,
Catalin-Stratulat-Ericsson and
tliron
| serverConfig.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig(sampleopenapi.GetOpenAPIDefinitions, openapi.NewDefinitionNamer(apiserver.Scheme)) | ||
| serverConfig.OpenAPIConfig.Info.Title = "Porch" | ||
| serverConfig.OpenAPIConfig.Info.Version = "0.1" | ||
| serverConfig.OpenAPIConfig.Info.Title = OpenAPITitle |
There was a problem hiding this comment.
Why did we have to change these lines?
|
|
||
| serverConfig.OpenAPIV3Config = genericapiserver.DefaultOpenAPIV3Config(sampleopenapi.GetOpenAPIDefinitions, openapi.NewDefinitionNamer(apiserver.Scheme)) | ||
| serverConfig.OpenAPIConfig.Info.Title = OpenAPITitle | ||
| serverConfig.OpenAPIConfig.Info.Version = OpenAPIVersion |
There was a problem hiding this comment.
Why dod we need to add these lines?
| const ( | ||
| defaultEtcdPathPrefix = "/registry/porch.kpt.dev" | ||
| OpenAPITitle = "Porch" | ||
| OpenAPIVersion = "0.1" |
There was a problem hiding this comment.
And here, could you explain what's going on?
There was a problem hiding this comment.
Just defining some constants for the openapi(v3) config.
|
I downloaded this PR and Porch now runs locally for me. |
With the upgrade k8s apiserver, the ApplyTo(config *server.RecommendedConfig) requires that the *restclient.Config be set. With how the run is standalone-debug mode was being set up, the RecommendedOptions.CoreAPI was being set to nil meaning that the default restclient would not be setup. So the fix was to remove the nil set above. |
|
Thanks @efiacor |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.