Add metrics filtering to devices query #1598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elinol did you want a code review on this PR? |
|
@elinol oh yeah, I noticed that this is still in Draft, is this ready for review? |
elinol
force-pushed
the
filter-devices-on-metrics
branch
from
e02b266
to
5f5b145
Compare
|
@joshk I don't remember why there's no filters selectors added to the UI, did we wanna wait for the new UI? I could add them before merging this, or after if preferred. |
|
I think it might be good to add it to the current UI, as the new UI is still a little bit away. |
elinol
commented
Nov 18, 2024
| @@ -221,10 +225,38 @@ defmodule NervesHub.Devices do | |||
| else | |||
| query | |||
| end | |||
|
|
|||
| {_, _} -> | |||
There was a problem hiding this comment.
I added this (realized now it could be just a _ ..) instead of cases for {:metrics_key, _} and {:metrics_operator, _} since they depend on :metrics_value to execute anything. Any thoughts on that @joshk ?
|
Before selecting a metric: After selecting the other inputs will display: |
elinol
force-pushed
the
filter-devices-on-metrics
branch
from
b9289c0
to
4ac3549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements filtering on metric values.
What we want is to:
get all devices where the latest associated device metric for specified key is matching the provided filter (greater or less than X)
The current query gives the latest device metric where the requirements are met, so if there are at least one metric report that match for a device, that device will be included in result, no matter the timestamp.Queries the latest inserted record for given metrics key, and checks if it matches the filter.
Includes a simple little functionality for testing in browser, just add params like
?metric=cpu_temp&metric_operator=gt&metric_value=37.0to devices URL.