Bump phoenix_test from 0.3.1 to 0.4.2 #1601
Open
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [phoenix_test](https://github.com/germsvel/phoenix_test) from 0.3.1 to 0.4.2. - [Changelog](https://github.com/germsvel/phoenix_test/blob/main/CHANGELOG.md) - [Commits](germsvel/phoenix_test@v0.3.1...v0.4.2) --- updated-dependencies: - dependency-name: phoenix_test dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
nshoes
force-pushed
the
dependabot/hex/phoenix_test-0.4.2
branch
from
b5759b0
to
19c14a1
Compare
nshoes
reviewed
Oct 31, 2024
| |> select( | ||
| "#{firmware.version} #{firmware.platform} #{firmware.architecture} #{firmware.uuid}", | ||
| from: "Firmware version" | ||
| ) | ||
| |> click_button("Create Deployment") |
There was a problem hiding this comment.
@joshk looking for some direction here before I venture out of this repo for answers. The change I made from fill_in -> select works, but now this test fails on submit:
1) test new deployment the happy path, with an audit log (NervesHubWeb.Live.Deployments.NewTest)
test/nerves_hub_web/live/deployments/new_test.exs:9
** (ArgumentError) could not find non-disabled input, select or textarea with name "deployment[platform]" within:
<input class="form-control" id="name_input" name="deployment[name]" type="text"/>
<input class="form-control" id="tags_input" name="deployment[tags]" type="text" value=""/>
<select class="form-control" id="firmware_id" name="deployment[firmware_id]" required="required"><option value="">Choose a firmware version</option><option value="1564">1.0.0 taramasalata x86_64 8dc5f02a-298f-5890-bbda-b697d1b88d47</option></select>
<input class="form-control" id="version_input" name="deployment[version]" type="text" value=""/>
code: |> click_button("Create Deployment")
stacktrace:
(phoenix_live_view 0.20.17) lib/phoenix_live_view/test/live_view_test.ex:1102: Phoenix.LiveViewTest.call/2
(phoenix_test 0.4.0) lib/phoenix_test/live.ex:328: PhoenixTest.Live.submit_form/4
test/nerves_hub_web/live/deployments/new_test.exs:32: (test)
Phoenix.LiveViewTest is looking for deployment[platform], but the form element no longer exists because of the logic in deployments/new.html.eex.
Have you seen anything like this before? I have experience with LiveView, but not testing it with phoenix_test. I did verify this broke in 0.4.0 of phoenix_test.
There was a problem hiding this comment.
You can leave this with me as I was in talks with German (the author of the lib) about the issues I saw with upgrading; I just put this to the side temporarily as I picked up other items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps phoenix_test from 0.3.1 to 0.4.2.
Changelog
Sourced from phoenix_test's changelog.
... (truncated)
Commits
d3196cePublish version 0.4.224192e2Fix: do not recycle fresh conn5b25afcRefactor: move all element-like modules under Elementc3c9c87Publish version 0.4.10d54b49Updatephx_click?to check for valid JS commands (#139)e950ae4Deduplicate data passed to FormPayload (#137)7df460aExtract payload operations into FormPayload06e43e9Move name validation out of FormData parsingba34d9aEncapsulate FormData data structureb37199dRename build_data -> build_payload to clarifyYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)