Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update idna #4754

Merged
merged 2 commits into from
Dec 18, 2024
Merged

chore(deps): update idna #4754

merged 2 commits into from
Dec 18, 2024

Conversation

doitian
Copy link
Member

@doitian doitian commented Dec 17, 2024 •
edited
Loading

What problem does this PR solve?

ID: RUSTSEC-2024-0421
Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0421

What is changed and how it works?

What's Changed:

  • update url
  • update or replace trust-dns-resolver

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    • cargo deny check --hide-inclusion-graph --show-stats advisories sources

Release note 

None: Exclude this PR from the release note.

@doitian
chore: cargo update url
3166f21 
For security vulnerability

ID: RUSTSEC-2024-0421
Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0421
@doitian
Copy link
Member Author

doitian commented Dec 17, 2024

There's no available version of trust-dns-resolver to update. The project seems has been replaced by https://github.com/hickory-dns/hickory-dns

@doitian doitian changed the title deps: update idna chore(deps): update idna Dec 18, 2024
@doitian doitian marked this pull request as ready for review December 18, 2024 01:05
@doitian doitian requested a review from a team as a code owner December 18, 2024 01:05
@doitian doitian requested review from zhangsoledad and driftluo and removed request for a team and zhangsoledad December 18, 2024 01:05
@doitian doitian added the s:blocking Status: This PR must be merged first label Dec 18, 2024
doitian
doitian commented Dec 18, 2024
View reviewed changes
deny.toml
@@ -103,6 +103,7 @@ allow = [
"CC0-1.0",
"Unicode-DFS-2016",
"OpenSSL",
"Unicode-3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For icu dependencies

@doitian doitian added this pull request to the merge queue Dec 18, 2024
Merged via the queue into nervosnetwork:develop with commit 9be53ff Dec 18, 2024
33 checks passed
@doitian doitian mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
s:blocking Status: This PR must be merged first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doitian @eval-exec