Trim the excessive logged stack trace for missing WARC files #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing WARC files, typically caused by a dismounted network drive or a moved folder, causes excessive track traces in the logs when performing playback of webpages. This pull request changes the code to
FileNotFoundException
at the root levelArcSource.get()
FileNotFoundException
at the calling levelArcParserFileResolver.getArcEntry(...)
, culling the stack trace and converting it to a proper HTTP 404 service exception.After this pull request, the log entries from a missing WARC will be
The first (the "real" message) is from the logger @
ArcSource
and is enables closer bug finding. The second is from the Exception handler in theSolrWaybackResource
and is unavoidable with the current architecture as the old contract is that the exception message will be logged here.This closes #414