Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Ignore route rules with no sources instead of erroring out #2786

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Oct 25, 2024

Describe your changes

  • Ignores empty sources when applying route rules
  • Accumulates errors and returns them when applying route rules

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

sonarcloud bot commented Oct 25, 2024

@lixmal lixmal merged commit 46e37fa into main Oct 28, 2024
21 checks passed
@lixmal lixmal deleted the ignore-empty-sources branch October 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants