Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client>android] add serial, product model, product manufacturer #2958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdouardVanbelle
Copy link
Contributor

Hello please find the propagation of android device serial

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@EdouardVanbelle EdouardVanbelle force-pushed the android-serial branch 8 times, most recently from ab932db to 4fe43ac Compare November 28, 2024 06:48
@mlsmaycon mlsmaycon requested a review from pappz December 5, 2024 10:36
@pappz
Copy link
Contributor

pappz commented Dec 5, 2024

Dear @EdouardVanbelle
Your PR looks fine for the first look. Could you set the state to "Ready for review"?

@EdouardVanbelle
Copy link
Contributor Author

Hello @pappz, I did not took time to test it, which is why this PR is still in progress

@pappz pappz marked this pull request as ready for review December 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants